Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Fix Python 3.12 SyntaxError with regex escape sequences #82290

Conversation

akien-mga
Copy link
Member

I ran into errors with these on a Fedora 39 container.

@akien-mga akien-mga added bug topic:buildsystem cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Sep 25, 2023
@akien-mga akien-mga added this to the 4.2 milestone Sep 25, 2023
@akien-mga akien-mga requested review from a team as code owners September 25, 2023 08:40
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a correct usage of r-strings.

@akien-mga akien-mga merged commit 23a4c8d into godotengine:master Sep 25, 2023
15 checks passed
@akien-mga akien-mga deleted the scons-python3.12-syntax-error-escape-sequences branch September 25, 2023 15:22
@akien-mga
Copy link
Member Author

Cherry-picked for 4.1.2.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 3, 2023
@akien-mga
Copy link
Member Author

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 16, 2024
@akien-mga
Copy link
Member Author

Cherry-picked for 3.5.4.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants