Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Font and Mesh icons that aren't grayed out #82302

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

MewPurPur
Copy link
Contributor

Font is an abstract class, so it uses a gray icon now. But some places used the class icon and aren't supposed to look disabled. Fixes this:

image

@MewPurPur MewPurPur requested a review from a team as a code owner September 25, 2023 12:54
@YuriSizov
Copy link
Contributor

That's exactly what I was referring to in #80184 (comment) 😛

These icons may be used for things other than node types in the editor. And in those cases it is very likely important that icons have their assigned color palette

YuriSizov
YuriSizov previously approved these changes Sep 25, 2023
@MewPurPur
Copy link
Contributor Author

MewPurPur commented Sep 25, 2023

Ooh, I see now. I got confused with the English, I thought you meant that in the future, they might be used for something else (as in, a feature or sth). But I think it's fine to split off into multiple icons for the different contexts.

Alright, wait a sec, I'll check if there might be other icons with this issue, so I won't have to make more of these PRs.

@YuriSizov
Copy link
Contributor

That's why using modulation for your original PR would've been great, so we don't duplicate icons just to adjust the color, and waste all the space that you've otherwise saved.

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Sep 25, 2023

Mesh also popped up in a few other places. It used to be yellow, now I made the new variant white (afaik this seems fine, given the context, but I'm not heavy on 3D scene importing)

IMO it's best to have "de facto" class icons that are shown everywhere the same, even if it is slightly more taxing. I think otherwise we'd have to think about all the places modulation is needed or not, as opposed to just some uncoupling.

@MewPurPur MewPurPur changed the title Add a white Font icon Add Font and Mesh icons that aren't grayed out Sep 25, 2023
@YuriSizov YuriSizov dismissed their stale review September 25, 2023 14:15

More changes needed

@akien-mga akien-mga merged commit fcbc50e into godotengine:master Sep 25, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur deleted the alt-font-icon branch September 25, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants