-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Font and Mesh icons that aren't grayed out #82302
Conversation
That's exactly what I was referring to in #80184 (comment) 😛
|
Ooh, I see now. I got confused with the English, I thought you meant that in the future, they might be used for something else (as in, a feature or sth). But I think it's fine to split off into multiple icons for the different contexts. Alright, wait a sec, I'll check if there might be other icons with this issue, so I won't have to make more of these PRs. |
That's why using modulation for your original PR would've been great, so we don't duplicate icons just to adjust the color, and waste all the space that you've otherwise saved. |
d39f0df
to
2276d34
Compare
Mesh also popped up in a few other places. It used to be yellow, now I made the new variant white (afaik this seems fine, given the context, but I'm not heavy on 3D scene importing) IMO it's best to have "de facto" class icons that are shown everywhere the same, even if it is slightly more taxing. I think otherwise we'd have to think about all the places modulation is needed or not, as opposed to just some uncoupling. |
2276d34
to
fb030be
Compare
Thanks! |
Font is an abstract class, so it uses a gray icon now. But some places used the class icon and aren't supposed to look disabled. Fixes this: