Optimizing glow behavior #82353
Merged
Optimizing glow behavior #82353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPicster
force-pushed
the
optimizing-glow
branch
2 times, most recently
from
3ccbec0
to
bd4b8f2
Compare
RPicster
force-pushed
the
optimizing-glow
branch
from
bd4b8f2
to
f42d895
Compare
akien-mga
reviewed
Sep 26, 2023
RPicster
force-pushed
the
optimizing-glow
branch
from
f42d895
to
de42258
Compare
clayjohn
approved these changes
Sep 26, 2023
|
Thanks! |
|
Thanks guys!!! I've been waiting for this, looks amazing 🙏🙏🙏🙏🔥🔥🔥🔥🔥🔥 |
|
Finally we can have glowing laser beams and small neon signs in the distance which actually look like neon signs! ❤️ |
|
Looks awesome!!! Thank you tons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #56452 and fix #57693
I was working on this with @clayjohn who contributed a lot of the code and knowledge, thanks for that!
The current glow shader implementation was lacking a bit in comparison to the high-quality glow in Godot 3.
This PR fixes this by giving the glow one more sample level and also fixes the boxiness with improved sigma values.
Current glow in a test scene (Small glow missing and box shape):
This PR:
We also checked against fireflies and with this implementation, no fireflies are to be found.
On very strongly glowing objects that are very small, a kinda similar effect can be noticed - But this can be "fixed" by changing the
glow_luminance_cap.