Fix crash when deleting the player in AnimationPlayerEditorPlugin
#82573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
fix_animationtree_crash
branch
from
4b020b0 to
01d79a4
Compare
Chaosus
force-pushed
the
fix_animationtree_crash
branch
from
01d79a4 to
8980211
Compare
Chaosus
changed the title
AnimationPlayerEditorPluginAnimationPlayerEditorPlugin
TokageItLab
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
I have not been able to test this because I am exactly away from home, but I don't think this fix will be a major problem since it is a destructor behavior change. In any case, crashes should be avoided and should be fixed later if this causes regressions.
It would be helpful if someone could test just to see if the dummy player pointer is broken or not when using AnimationTree.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #82549
The player is just a weak pointer, which doesn't allocate and shouldn't free in this class: