Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix godot_js_wrapper_create_cb regression #82736

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix godot_js_wrapper_create_cb regression #82736

merged 1 commit into from
Oct 4, 2023

Conversation

adamscott
Copy link
Member

Fix a regression caused by #81105.

Currently, calling GodotJSWrapper.MyProxy(args) without the new keyword returns undefined, which make the following calls fail.

This PR adds the missing new keyword to the expression.

Fixes #82734

@adamscott adamscott requested a review from Faless October 3, 2023 16:52
@adamscott adamscott self-assigned this Oct 3, 2023
@adamscott adamscott added this to the 4.2 milestone Oct 3, 2023
@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 3, 2023
@akien-mga akien-mga mentioned this pull request Oct 3, 2023
Merged
akien-mga
akien-mga approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's consistent with #81090, so this was likely a mistake when forward porting from 3.x.

@SysError99
Copy link
Contributor

Thank you for your dedication to fix my mistake 😭

@akien-mga akien-mga merged commit a904e78 into godotengine:master Oct 4, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Faless Faless Faless approved these changes

Assignees

@adamscott adamscott

Labels
bug platform:web regression topic:porting
Projects
4.x Release Blockers
Archived in project
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Calling a JavascriptBridge.create_callback() callback from Javascript fails
5 participants
@adamscott @SysError99 @akien-mga @YuriSizov @Faless