Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes extents to size conversion #82754

Merged

Conversation

BrunoArmondBraga
Copy link
Contributor

This rename conversion is no longer necessary because BoxShape3D, RectangleShape2D, ReflectionProbe and other classes already handle the extents property internally. Renaming extents was actually causing problems, since in Godot 4.x the classes mentioned started to use the size property and size (extents "equivalent") = 2 * extents.

Just clarifying, as LightmapGI was mentioned in the code comment, the conversion does not make sense in LightmapGI case since this class doesn't have a size property in Godot 4.x.

Fixes #77931

Co-authored-by: Guilhermev25 <guilhermeferreira2529@hotmail.com>
@akien-mga akien-mga added this to the 4.2 milestone Oct 3, 2023
@akien-mga akien-mga merged commit 7a9947f into godotengine:master Oct 4, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants