Consider script-defined static methods for the validity of callables #82770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
added
bug
topic:core
topic:gdscript
cherrypick:4.1
akien-mga
reviewed
Oct 4, 2023
akien-mga
approved these changes
Oct 4, 2023
RandomShaper
force-pushed
the
fix_callable_static
branch
from
352a5c8 to
9278447
Compare
RandomShaper
force-pushed
the
fix_callable_static
branch
from
9278447 to
524dba5
Compare
dalexeev
reviewed
Oct 4, 2023
|
Counter-superseded by the revised #82767. |
akien-mga
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #82767.
Bugsquad edit: Also supersedes #82755.
See #82767 (comment) there for the whole rationale for this PR.
Fixes #79521.
Dear Production team. I've checked this fixes the MRP in the issue, but haven't performed exhaustive smoke testing.