-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web: Catch using GDExtensions in a non-dlink build #82790
Conversation
Would be good to provide information about:
The UX is a bit awkward as "Extensions Support" I believe only toggles which of the official templates will be used, but if using custom built ones this logic doesn't apply. |
Should it even be an option? I'd say the editor should know there's an GDExtension somewhere, so it could pick it automatically or warn the user if there's no matching template. I mostly got into this situation by using a symbolic link from |
Discussed at the GDExtension meeting, and we agree that this PR is a good idea, but also agree with @akien-mga that the message should contain some information for the developer about what to do to fix the issue. |
a2c71a7
to
1fd65b0
Compare
Previously this would simply fail with a cryptic `me.rtenv.loadDynamicLibrary is not a function` error.
1fd65b0
to
56a3cdc
Compare
Done. It will now read:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That message sounds good to me!
Thanks! |
Previously, if one would try to use GDExtensions with a web build that doesn't have dynamic loading enabled, this would simply fail with a cryptic
me.rtenv.loadDynamicLibrary is not a function
error message.If it's attempted again, it will now instead error out with
GDExtension libraries are not supported by this engine version
.