Automatically ensure correct normals in Compatibility renderer #82804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCube3310
force-pushed
the
compat_correct_normals
branch
from
1e8a23a
to
8ab0c94
Compare
|
As Calinou mentioned earlier #82763 (comment), I think we should make this consistent with the Forward+ and Mobile renderers instead of making it use the render mode. Matching behaviour between the renderers is more important than saving a single integer uniform |
BlueCube3310
changed the title
ensure_correct_normals in Compatibility renderer
BlueCube3310
changed the title
BlueCube3310
force-pushed
the
compat_correct_normals
branch
2 times, most recently
from
2c13eba
to
4de577c
Compare
BlueCube3310
force-pushed
the
compat_correct_normals
branch
from
4de577c
to
f31371c
Compare
clayjohn
approved these changes
Nov 13, 2023
clayjohn
added
the
cherrypick:4.2
Is this implemented now in the latest revision of this PR? If not, I suggest opening another issue to track this once this is merged. |
|
I haven't made much progress on the instanced rendering part, so I will do as suggested. Edit: I've opened the new issue here: #84903 |
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82763
The
ensure_correct_normalsdefine is redundant in the Forward+ and Mobile renderers, as they check whether individual instances are uniform or not.Due to the way instancing is done in the Compatibility renderer, however, theENSURE_CORRECT_NORMALSshader define has to be used instead.This PR changes the shader's logic to automatically figure out which objects have a non-uniform scale.
Results (Compatibility):
Progress: