Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the behavior of get_tree() when the node is not in the scene tree #82863

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

HexagonNico
Copy link
Contributor

Specify in the docs of Node that get_tree() returns null if it is called on a node that is not inside the scene tree.

@HexagonNico HexagonNico requested a review from a team as a code owner October 5, 2023 16:21
@Calinou Calinou added enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 5, 2023
@Calinou Calinou added this to the 4.2 milestone Oct 5, 2023
doc/classes/Node.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I rebased and squashed commits on your behalf so this can be merged quickly. We prefer when each PR is contained within on commit, so in future please squash/fixup commits when applying suggestions or doing further changes to your PR. See this documentation, if you need help with squashing.


I also removed a line break because that would generate a new paragraph in printed documentation, and this would be excessive for such a short description.

@akien-mga akien-mga merged commit 76d9521 into godotengine:master Nov 10, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga akien-mga changed the title Specify the behaviour of get_tree() when the node is not in the scene tree Specify the behavior of get_tree() when the node is not in the scene tree Nov 29, 2023
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants