Fixes internal Script Editor crash with External Editor active #82956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
ryanabx
approved these changes
Oct 9, 2023
|
Looks good! Could you squash the commits? See PR workflow for instructions. |
when the external Editor is active in the settings. This prevents a crash from different race conditions from edititing files in the external editor while the internal editor tries to reload open file tabs. Some conditions that cause the crash where: * Syntax highlighting (gdscript_highlighter.cpp, syntax_highlighter.cpp) * Code analysis (code_edit.cpp) * ... and more
Chtau
force-pushed
the
GDScript-external-Editor-Engine-crash
branch
from
b1a3c9b to
2929993
Compare
adamscott
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Seems fine. Could be merged for the next beta!
@akien-mga It seems that the PR is now squashed. :)
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the internal Script Editor from reloading when the external Editor is active in the settings.
This prevents a crash from different race conditions from editing files in the external editor while the internal editor tries to reload open file tabs.
Some conditions that cause the crash where:
gdscript_highlighter.cpp,syntax_highlighter.cpp)code_edit.cpp)This solves the crashes mentioned in #71016
I was able to reproduce the different crashes as mentioned in #71016 (comment)