Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation on which buttons JOY_BUTTON_START corresponds to #83013

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Add documentation on which buttons JOY_BUTTON_START corresponds to #83013

merged 1 commit into from
Oct 11, 2023

Conversation

RobTheFiveNine
Copy link
Contributor

The existing documentation for JoyButton.JOY_BUTTON_START only mentions the Nintendo button it corresponds to, that being:

Game controller SDL start button. Corresponds to the Nintendo + button.

This PR updates it to also include the PlayStation and Xbox buttons it corresponds to, the names for the updated documentation are taken from the corresponding manuals at:

@RobTheFiveNine RobTheFiveNine requested a review from a team as a code owner October 8, 2023 20:40
@Sauermann Sauermann added this to the 4.2 milestone Oct 9, 2023
@akien-mga akien-mga merged commit 3126001 into godotengine:master Oct 11, 2023
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@RobTheFiveNine
Copy link
Contributor Author

Thanks! And congrats for your first merged Godot contribution 🎉

Thanks!

@RobTheFiveNine RobTheFiveNine deleted the documentation/start_button branch October 11, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@RobTheFiveNine @akien-mga @Sauermann