-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Fix glGet
overflows by using 64 bit versions
#83031
Conversation
5ee0b24
to
015fa5a
Compare
Let me know if there are any more than get spotted that should be 64 bit from the spec, I've tried to catch the ones from #80909 . For the shaders, instead of reading UBO SizeThe UBO size seems to be the primary bug, and I have expanded some comments to discuss this. The problems seem to occur under ANGLE.
There is thus no ideal way to deal with this situation, and we have to compromise. We could e.g.:
I've gone for (2) here, which still allowing for using larger sizes up to a megabyte, which we seem unlikely to use over in Godot 3.x. |
015fa5a
to
b1b2cc8
Compare
Certain glGet operations require 64 bit versions according to the GLES spec. The previous code was susceptible to overflow bugs, especially running under ANGLE.
b1b2cc8
to
6ff3700
Compare
Thanks! |
glGet
overflows by using 64 bit versions
Certain glGet operations require 64 bit versions according to the GLES spec. The previous code was susceptible to overflow bugs, especially running under ANGLE.
May fix #75913
Notes
gl_wrapper
by placing an upper limit on texture image units.GL_MAX_UNIFORM_BLOCK_SIZE
overflowing #80909 .