Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: An attempt to fix missing link. issue #82495 #83073

Closed
wants to merge 1 commit into from

Conversation

realdezzy
Copy link

I added a link to the README in version 3.5 because it seems clear and to the point. Although I think adding a README to the newer versions would be better

I added a link to the README in version 3.5 because it seems clear and to the point.
Although I think adding a README to the newer versions would be better
@akien-mga
Copy link
Member

Thanks for the contribution. Linking to an old branch isn't the right solution, it should be linking to the new location for this documentation.

I went ahead and made my own update of the docs: #83095.

In general, we advise against new contributors making minor changes to repository documentation like this. This requires a lot of effort from maintainers to help shape the contribution so that it fits our PR workflow and style guides, for very minor changes.

@realdezzy
Copy link
Author

The PR was basically to bring a maintainer's attention to the error, I wasn't expecting it to get merged. Thanks for your work and contribution

@realdezzy realdezzy deleted the realdezzy-patch-1 branch October 10, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants