Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't auto translate theme type list #83177

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

timothyqiu
Copy link
Member

Auto translate is on by default, so listed theme types like "Button" may be translated (e.g. it shows "按钮" in Chinese version).

When the list is empty, "None" is still translated because it's explicitly using TTR().

@timothyqiu timothyqiu added bug topic:editor cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 12, 2023
@timothyqiu timothyqiu added this to the 4.2 milestone Oct 12, 2023
@akien-mga akien-mga merged commit 94a8d37 into godotengine:master Oct 13, 2023
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the the-theme-identity branch October 13, 2023 10:01
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants