Keep focus on floating window when showing ProgressDialog #83290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trollodel
force-pushed
the
move_progress_dialog_on_open
branch
2 times, most recently
from
841db2c to
be88020
Compare
Maran23
reviewed
Oct 15, 2023
trollodel
force-pushed
the
move_progress_dialog_on_open
branch
from
be88020 to
9ae48c7
Compare
KoBeWi
approved these changes
Oct 16, 2023
|
That PR would allow to get rid of the whole Though the current code is only limited to the wrapped windows, so we won't get popups or transient windows unexpectedly getting progress dialog. This is a safer approach, not sure if it matters. |
|
btw the linked issue is already "fixed" so this PR can be postponed too probably. |
YuriSizov
approved these changes
Nov 15, 2023
akien-mga
approved these changes
Nov 15, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78672
This uses the first approach described in #78672 (comment)
I tested this only on Linux (KDE neon 5.27 22.04 - X11 - Vulkan (Forward+) - dedicated AMD Radeon Graphics (RADV NAVI23) - AMD Ryzen 5 5600 6-Core Processor (12 Threads)).
Other OSes should be tested as well, just in case any of them doesn't like quick focus changes.
I have done this patch ~2 months ago, but I never get to publish it 🙈.
Initially, I want to base this PR to #79261, but it's not merged.