Fix SkeletonModification2DLookAt with negative scales #83330
+18
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80252.
This is an attempt to fix SkeletonModification2DLookAt when only one scale is negative.
Instead of getting the transform and operate over it, changes will happen through Node2D methods. I'm doing this because we can't decompose X negative scale from transforms, which means that you would have to replicate what Node2D already does (recovering the correct scale).
I'm operating over the angle and only at the end call methods like
set_rotation()
(i'm just reducing method calls).Adding X to local rotation would also means that the global will increase by X, right? That's why I'm just adding to global rotation without any conversion.