Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple comment delimiter break toggle comment shortcut #83382

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix multiple comment delimiter break toggle comment shortcut #83382

merged 1 commit into from
Oct 16, 2023

Conversation

Lunarisnia
Copy link
Contributor

Fixes #83331

@Lunarisnia Lunarisnia requested a review from a team as a code owner October 15, 2023 11:34
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 15, 2023
AThousandShips
AThousandShips reviewed Oct 15, 2023
View reviewed changes
editor/code_editor.cpp Outdated Show resolved Hide resolved
editor/code_editor.cpp Outdated Show resolved Hide resolved
SaracenOne
SaracenOne approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, does what it says, LGTM

@akien-mga
Copy link
Member

Looks good! Could you squash the commits? See PR workflow for instructions.

@Lunarisnia
Copy link
Contributor Author

sure thing!

@akien-mga akien-mga merged commit a60fc7f into godotengine:master Oct 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@SaracenOne SaracenOne mentioned this pull request Oct 27, 2023
Merged
@kitbdev kitbdev mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Code editor toggle comment doesn't uncomment if there's a different amount of #'s
4 participants
@Lunarisnia @akien-mga @SaracenOne @AThousandShips