Allow normal maps on TileMaps that use texture padding #83489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supersedes #79823. It's simpler and I forgot reacting on |
YuriSizov
reviewed
Oct 17, 2023
YuriSizov
reviewed
Oct 17, 2023
YuriSizov
reviewed
Oct 17, 2023
groud
force-pushed
the
implement_tile_map_normals
branch
from
78dcb94 to
1d04829
Compare
KoBeWi
reviewed
Oct 18, 2023
KoBeWi
reviewed
Oct 18, 2023
KoBeWi
reviewed
Oct 18, 2023
KoBeWi
reviewed
Oct 18, 2023
KoBeWi
reviewed
Oct 18, 2023
KoBeWi
reviewed
Oct 18, 2023
groud
force-pushed
the
implement_tile_map_normals
branch
from
1d04829 to
73f7240
Compare
KoBeWi
approved these changes
Oct 18, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61832
I added it for 4.2 and used the "bug" as the original issue is labeled the same. But I guess, if that's too risky, it could be moved to 4.3.