-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass viewport size to shadow pass instead of using Vector2i(1,1) #83491
Pass viewport size to shadow pass instead of using Vector2i(1,1) #83491
Conversation
Putting it last is fine. This commit looks fine, please make the same change to the compatibility renderer and then it should be ready to merge! |
d85a2b0
to
42a7884
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Let's not cherrypick this one as it will introduce a behaviour change if someone was erroneously relying on VIEWPORT_SIZE being (1,1) (for example to modify the shader when in a shadow pass)
servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.h
Outdated
Show resolved
Hide resolved
servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.cpp
Outdated
Show resolved
Hide resolved
servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.cpp
Outdated
Show resolved
Hide resolved
servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.h
Outdated
Show resolved
Hide resolved
42a7884
to
26d3255
Compare
Thanks! |
Fixes #82782
Two things to improve:
p_viewport_size
to the last but it may better be inserted somewhere front