Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shortcut input for EditorSceneTabs #83501

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Oct 17, 2023

Seems like an oversight from when the tab was split off into its own component (in #80490)

@@ -341,6 +341,8 @@ void EditorSceneTabs::_bind_methods() {
EditorSceneTabs::EditorSceneTabs() {
singleton = this;

set_process_shortcut_input(true);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure where to place this, i.e. if the order matters, can move if it does matter

Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. Surprised it took so long for anyone to notice.

@AThousandShips
Copy link
Member Author

Me too, but I haven't used the shortcut myself so unsure how many do

@akien-mga akien-mga merged commit 30f2a6d into godotengine:master Oct 17, 2023
14 checks passed
@AThousandShips AThousandShips deleted the tabs_shortcut branch October 17, 2023 14:25
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't switch scene tabs using shortcut anymore
3 participants