Make ProgressBar reflect the real value in the percent label when "allow greater" is checked

[rarysson]

Fix #63311.

I have just a question. When we change the min value or the max value, the current value is updated if it is above the max value or below the min value. Should I implement this behavior when the user toggles Allow Greater/Lesser? Right now if I toggle Allow Greater/Lesser it will keep the old value, as you can see in the video below.

progressbar.mp4

It seems because in the Range class it doesn't emit the change like the other properties (e.g.: page, max, min, etc.).

godot/scene/gui/range.cpp

Lines 360 to 362 in f8818f8

	void Range::set_allow_greater(bool p_allow) {
	shared->allow_greater = p_allow;
	}

[KoBeWi]

You can't just divide by max, you need to take min into account also avoid dividing by 0.

[rarysson]

It was too good to be right on the first try haha.

Now I just need to know if I need to fix the behavior that I mentioned in the video, or if it's expected.

[KoBeWi]

It breaks exp_edit though:

I think instead of inventing custom ratio, get_as_ratio() should be modified to allow values outside the 0-1 range if allow_greater/allow_lesser are enabled. The value is explicitly clamped, so it should be easy change.

It seems because in the Range class it doesn't emit the change like the other properties

This is irrelevant, because changing these properties does not affect current value.

[rarysson]

You're right, it would be much simpler, but I don't think we can do that safely, because some UI elements rely on the value from get_as_ratio(), and it will break if the value is outside of the 0-1 range, as you can see below:

I just have one question, if the exp_edit and allow_lesser are checked what is the expected behavior if the value is less than or equal to 0?

[KoBeWi]

I just have one question, if the exp_edit and allow_lesser are checked what is the expected behavior if the value is less than or equal to 0?

exp_edit requires the min_value to be >= 0, so I think the exp ratio should be always 0 when below that.

btw "exp_edit requires the min_value to be >= 0," is not respected by your code. I think the implementation is ok, just make sure that the percentage always matches the filled bar, i.e. 50% should be when the bar is half filled etc. Right now it's still possible to desync it.

[rarysson]

[...] I think the implementation is ok, just make sure that the percentage always matches the filled bar, i.e. 50% should be when the bar is half filled etc. Right now it's still possible to desync it.

To be honest, I don't see how it could desync, because it's the same logic as the get_as_ratio(), do you have an example?

I tried to see if it behaved differently from the stable version, but I don't see the difference, as you can see below (I tried some different values too).

Godot 4.1

This PR

[KoBeWi]

Ok the only one I could find was with exp_edit (again xd) and negative min_value:

godot.windows.editor.dev.x86_64_wPldJzsHBo.mp4

Other than that the value displays correctly.

[rarysson]

Now I think it works as expected.

[YuriSizov]

Thanks, and congrats on your first merged Godot contribution!