Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visual shader crash when arranging #83678

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Fix visual shader crash when arranging #83678

merged 1 commit into from
Oct 28, 2023

Conversation

qycyfjy
Copy link

@qycyfjy qycyfjy commented Oct 20, 2023 •
edited
Loading

Fix #82166

  1. Fixed iterator invalidation: removing element when iterate over HashSet may cause some element cannot be removed properly.
  2. Remove some useless code.
  3. Rearrange code for reducing reinitialization.

@qycyfjy qycyfjy requested a review from a team as a code owner October 20, 2023 13:33
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 20, 2023
@AThousandShips AThousandShips requested a review from a team October 20, 2023 13:34
@AThousandShips AThousandShips changed the title Fixing visual shader crash when perform arrange Fixing visual shader crash when arranging Oct 20, 2023
SaracenOne
SaracenOne approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the code looks fine and the bug appears to be fixed. LGTM 👍

@akien-mga akien-mga merged commit 51875ac into godotengine:master Oct 28, 2023
15 checks passed
@akien-mga akien-mga changed the title Fixing visual shader crash when arranging Fix visual shader crash when arranging Oct 28, 2023
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees
No one assigned
Labels
bug crash topic:editor topic:shaders
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Visual Shader Arrange Nodes button crashes Godot
5 participants
@qycyfjy @akien-mga @SaracenOne @AThousandShips @kyaru92