Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDExtension: Fix variant_iter_get() actually calling iter_next() #83681

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Oct 20, 2023

While attempting to test PR godotengine/godot-cpp#1253, I discovered that GDExtension's variant_iter_get() was actually calling Variant::iter_next()! Probably a copy-paste mistake.

@dsnopek dsnopek added this to the 4.2 milestone Oct 20, 2023
@dsnopek dsnopek requested a review from a team as a code owner October 20, 2023 15:10
@dsnopek dsnopek added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 20, 2023
@akien-mga akien-mga merged commit f68fa0f into godotengine:master Oct 20, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 25, 2023
@dsnopek dsnopek deleted the gdextension-iter-get branch July 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants