Fix NavigationAgent3D stored y-axis velocity and make it optional #83705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NavigationAgent3D stored y-axis velocity and makes it optional.
smix8
force-pushed
the
agent_y_velocity_.4x
branch
from
59b0531 to
4771431
Compare
akien-mga
approved these changes
Oct 21, 2023
AThousandShips
approved these changes
Oct 21, 2023
|
Thanks! Merged without seeing the above review comments, but would be worth doing those changes in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NavigationAgent3D stored y-axis velocity and makes it optional.
Part of #83625 and similar issues.
The 2D avoidance runs on a flat plane so small uneven 3D geometry already causes very noticeable clipping. This property reapplies the y-axis velocity after the 2D avoidance step so it can help to mitigate that.
The problem from the linked (and other) issues was that users often do not set their velocity to zero when they stop their agent movement so this stored velocity gets reapplied every frame making the agent go up or down.