Fix missing NavigationAgent property updates in constructor #83814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes missing NavigationAgent property updates in constructor.
This was referenced Oct 23, 2023
smix8
added
the
cherrypick:4.2
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing NavigationAgent property updates in constructor.
Agent version of #83802 and #83812
In this case it wasn't to bad because avoidance properties were set with their functions below and most of them had no setter guards that would prevent the update, or they had a duplicate update later when joining the SceneTree so that blocking went mostly unnoticed.
Still, better change it now to stay consistent and have no rude awakening should someone change the defaults or add guards without double checking ... wouldn't happen to be future me obviously of course why would it, that never happens 😄.