Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Add support for native help menu search callbacks, integrate editor help. #83819

Merged
merged 1 commit into from
Feb 13, 2024
Merged

[macOS] Add support for native help menu search callbacks, integrate editor help. #83819

merged 1 commit into from
Feb 13, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 23, 2023

  • Allows using custom callback to integrate with macOS built in search bar in the Help menu.
  • Use it with the editor help.
editor_help.mov

Demo project: help_integration.zip

@bruvzg bruvzg added this to the 4.x milestone Oct 23, 2023
@bruvzg bruvzg marked this pull request as ready for review October 23, 2023 06:08
@bruvzg bruvzg requested review from a team as code owners October 23, 2023 06:08
@bruvzg bruvzg mentioned this pull request Oct 26, 2023
Merged
akien-mga
akien-mga approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. Didn't test.

@akien-mga
Copy link
Member

Needs rebase.

@akien-mga akien-mga merged commit 7b30203 into godotengine:master Feb 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 13, 2024
@bruvzg bruvzg deleted the mac_native_help branch March 6, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:macos topic:editor topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @akien-mga