-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save current tab in TabBar
and TabContainer
#83893
Conversation
I'd say the rearranging of the tabs is a separate thing and not relevant to the specific change of exposing the property for storage, this should be split into multiple PRs IMO |
@AThousandShips In For the |
That would indeed be required, as you didn't mention it in the PR either The rest should be separate to focus the review on just the issue |
2a5c50e
to
136d7a7
Compare
added the comment and undid the |
Does it only have to be above the current tab? If so I'd say to move it instead, like the other PR did I'd prefer as little changes as possible to solve the issue, generally the idea |
In |
Just make sure it doesn't affect any other properties (hence why moving only the relevant one is safer, and preferred) |
It looks like no properties are affected by tab count and tab count is not affected by any other properties. |
136d7a7
to
2307d9f
Compare
made |
2307d9f
to
a2751b3
Compare
a2751b3
to
3f496f6
Compare
3f496f6
to
8985a46
Compare
Thanks! |
fixes #50930
Removed
PROPERTY_USAGE_EDITOR
fromcurrent_tab
.For
TabBar
, moved tabs array above other properties (like howOptionButton
does it).For
TabContainer
, delayed settingcurrent_tab
untilready
so children are added first.