Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor stuck on HSplit in Advanced Importer #84003

Closed

Conversation

SaracenOne
Copy link
Member

Very minor cosmetic bug fix.
Closes #84002

@YuriSizov
Copy link
Contributor

Doesn't look like a minor or cosmetic bug. Seems like a bug with input handling in subviewports. I'm not sure this is a good solution, or indeed a good workaround.

@SaracenOne
Copy link
Member Author

Hmm...I can try and investigate this a bit deeper later on. The root cause seems to be that SubViewportContainer has special handling in _gui_input_event where it doesn't update the cursor if it's over one. I assume what it's meant to do is derive a cursor from the contents of the viewport, but since the viewport doesn't have an Control elements inside it, it may not be updating:

		if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_CURSOR_SHAPE) && !Object::cast_to<SubViewportContainer>(over)) {
			DisplayServer::get_singleton()->cursor_set_shape(ds_cursor_shape);
		}

@akien-mga
Copy link
Member

CC @Sauermann

@akien-mga
Copy link
Member

Superseded by #84661.

@akien-mga akien-mga closed this Nov 9, 2023
@AThousandShips AThousandShips removed this from the 4.2 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HSplit cursor gets stuck in Advanced Scene Importer when hovering 3D preview
4 participants