Fix friction being in the correct if/else branch #84028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 27, 2023
QbieShay
force-pushed
the
qbe/fix-damp-fric
branch
from
f8cd3da to
7bd56b1
Compare
clayjohn
reviewed
Oct 28, 2023
QbieShay
force-pushed
the
qbe/fix-damp-fric
branch
from
7bd56b1 to
bdbd13e
Compare
|
Done! |
clayjohn
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Looks good to me, i double checked the math and it seems to line up with the old damping.
Tested locally and it seems fine to me. I'm not really knowledgeable enough to say if it is correct or not.
I left one little nitpick to clean the code up a bit and reuse the v variable since we have it calculated anyway
QbieShay
force-pushed
the
qbe/fix-damp-fric
branch
from
bdbd13e to
99692be
Compare
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
QbieShay
force-pushed
the
qbe/fix-damp-fric
branch
from
99692be to
8f2a2ec
Compare
|
Updated |
clayjohn
approved these changes
Oct 30, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84009
Sorry for the regression