Add read-only info to resource embedded in other scenes. #84048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 27, 2023
SaracenOne
force-pushed
the
extra_readonly_info
branch
from
d17df79 to
ada1f66
Compare
|
Good call. I've updated it now, but I also removed the additional string assignment since the program flow you suggested means that it can simply fall through. I tested it in all the known situations and it seems to still behave fine as far as I can tell. |
akien-mga
approved these changes
Oct 27, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing 'read-only' info to the top of the inspector for situations where the inspector is viewing a resource which is part of another scene and therefore cannot be directly edited. This situation is usually not seen since when attempting to edit a resource which is linked to another scene (which wasn't imported), you can click 'edit' and will be taken directly to that scene and resource where you are allowed to perform your edits.
However, there are still some situations where you can be viewing a resource in another scene, such as using AnimationTreeEditor and viewing AnimationNodes from another scene. This PR provides consistent info to help the user understand why they are unable to edit a resource from the inspector in this situation rather than just showing them an unmodifiable inspector.
