Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UV editor not using texture transform #84076

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

aXu-AP
Copy link
Contributor

@aXu-AP aXu-AP commented Oct 27, 2023

If you set Polygon2D's texture transform (offset, scale or rotation), texture would still draw with default transform in UV editor.
Properties:
kuva
Bug in UV editor:
kuva
Fixed:
kuva
MRP: TextureTransformMRP.zip

I didn't find any existing issues about this. As a side effect of this fix, if you rotate the texture 90-270 degrees (and no offset), the texture isn't going to be in the initial view (it's rotated around the top-left corner). Well, it's better than texture appearing in the wrong place altogether, but might be a bit confusing. See #83731 for a fix for that problem (altough it should be updated for transformed textures after this pr).

@aXu-AP aXu-AP requested a review from a team as a code owner October 27, 2023 19:52
@AThousandShips AThousandShips added bug topic:editor topic:2d cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Oct 28, 2023
@AThousandShips AThousandShips added this to the 4.3 milestone Oct 28, 2023
@akien-mga akien-mga merged commit 9108445 into godotengine:master Dec 4, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 5, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.1.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants