-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Fix typo in ConcavePolygonShape2D/3D description #84111
Conversation
The same error is present in the 3D shape, can you fix that as well? Please update your code with |
Please also amend the commit message to be more explicit. See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind. Here it could be "doc: Fix typo in ConcavePolygonShape2D/3D description" |
Please squash your commits into one, see here, and use Also make the description: "doc: Fix typo in ConcavePolygonShape2D/3D description" note the 3D part |
Sorry for inconvenience. This should be all good now. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Cherry-picked for 4.1.4. While the change is minor and will affect translations, this was blatantly and misleadingly wrong before. So I concluded that it was worth it. |
Fix a typo that said ConvexPolygonShape2D instead of ConcavePolygonShape2D. ConcavePolygonShape2D is hollow and both this page and ConvexPolygonShape2D page confirms it.