Add descriptive warning for animation track hint fails. #84129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaracenOne
force-pushed
the
better_warning_for_track_hint_fail
branch
from
68f689d to
70d1d88
Compare
akien-mga
reviewed
Oct 29, 2023
SaracenOne
force-pushed
the
better_warning_for_track_hint_fail
branch
from
70d1d88 to
aafa1c8
Compare
|
Updated! |
akien-mga
reviewed
Oct 30, 2023
SaracenOne
force-pushed
the
better_warning_for_track_hint_fail
branch
from
aafa1c8 to
5c1142a
Compare
SaracenOne
changed the title
SaracenOne
force-pushed
the
better_warning_for_track_hint_fail
branch
from
5c1142a to
38e1dc8
Compare
SaracenOne
force-pushed
the
better_warning_for_track_hint_fail
branch
from
38e1dc8 to
8db9884
Compare
|
Okay, fixed (for real this time). |
akien-mga
approved these changes
Oct 30, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this does not properly fix this bug (#83421), I feel its somewhat lower priority at the moment, but this PR at least provides a more descriptive warning of what happened rather than just failing with a generic null error. An actual fix for this bug in the case of reported issue probably involves running the track hint AFTER animation has had chance to run one frame, but even if we add that handling, track hint detection can still fail, so the warning is still relevant.