Fix file rename crash after toggling split mode. #84217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaracenOne
force-pushed
the
fix_filesystem_rename_crash
branch
from
3d83af9 to
0a4a4d7
Compare
KoBeWi
reviewed
Oct 31, 2023
KoBeWi
approved these changes
Oct 31, 2023
|
@SaracenOne Could you apply the suggestion so we can merge this? |
SaracenOne
force-pushed
the
fix_filesystem_rename_crash
branch
from
0a4a4d7 to
7fea0ce
Compare
|
@YuriSizov Fixed! Should be good to go now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash which occurs if you highlight a file in the thumbnail browser, then toggle between the split modes, and attempt to rename it again while it still shows up as highlighted. It fixes this by attempting to implicitly set the 'current' id of the selected file in the _update_file_list function.
Closes #84215