Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add_submenu_item doc to mention that submenu should already exist #84283

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

jsjtxietian
Copy link
Contributor

Fixes #50555

@jsjtxietian jsjtxietian requested a review from a team as a code owner November 1, 2023 04:48
@jsjtxietian jsjtxietian changed the title Update add_submenu doc to mention that submenu should already exist Update add_submenu_item doc to mention that submenu should already exist Nov 1, 2023
@Calinou Calinou added enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Nov 1, 2023
@Calinou Calinou added this to the 4.2 milestone Nov 1, 2023
doc/classes/PopupMenu.xml Outdated Show resolved Hide resolved
doc/classes/PopupMenu.xml Outdated Show resolved Hide resolved
@YuriSizov YuriSizov merged commit 0b2f8ee into godotengine:master Nov 2, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@jsjtxietian jsjtxietian deleted the update-add_submenu-doc branch November 3, 2023 09:21
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PopupMenu: add_submenu() documentation does not tell that submenu should already exist
3 participants