Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify handling of activation & focus on Windows #84363

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

RandomShaper
Copy link
Member

I found the need for this while assessing #80548. The central ideas are these:

  • In Godot we don't really need to tell activation apart from focus. It's the same. The only need, given how the handle child windows, is to explicitly set focus to any window just activated (see the linked PR).
  • The handling of application-wide focus is reimplemented here in a more reliable way.
  • Certain timer hack is removed (while the issue it intended to fix, Popup menus do not close when other is opened (DisplayServer regression) #44953, is still gone).

@akien-mga
Copy link
Member

CC @bruvzg

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine, I have not found any issues. #44953 should not happen, since popups no longer take focus.

@akien-mga
Copy link
Member

Needs rebase.

@RandomShaper
Copy link
Member Author

Rebased. I will retest it again. Some additional re-testing from others would be appreciated.

@akien-mga akien-mga merged commit 02cb74e into godotengine:master Apr 6, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants