Remove unused NOTIFICATION_NODE_RECACHE_REQUESTED notification
#84419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
force-pushed
the
core-remove-orphan-notification
branch
from
5a02cbd
to
5481cca
Compare
fire
approved these changes
Nov 3, 2023
raulsntos
approved these changes
Nov 3, 2023
Bromeon
reviewed
Nov 6, 2023
YuriSizov
force-pushed
the
core-remove-orphan-notification
branch
from
5481cca
to
623b905
Compare
|
Thanks for reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #82471. The notification was never used by the engine since the moment it was introduced in Godot 4 during its closing days of the development (#57606). It was sent, but never received by anything. While #82471 attempted to finally utilize it, the consensus was that the notification was a mistake and we should resolve the issue another way. Which we did.
So now the notification can be removed. This breaks compatibility, but there is no reason to assume users would rely on it in practice.
It also conflicts with some other notifications (see #75839), making it a problem for some GDExtensions.