Optimize String.humanize_size()
#84462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewPurPur
force-pushed
the
optimize-humanizesize
branch
from
315065d
to
7e8e165
Compare
MewPurPur
force-pushed
the
optimize-humanizesize
branch
from
7e8e165
to
931928f
Compare
akien-mga
changed the title
String.humanize_size()
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might seem like grasping, but this function is actually surprisingly hefty for a String method.
Using this method 1000 times used to take ~3 ms in production builds and ~7.6 ms in unoptimized development builds. Now it's ~1.8 ms in unoptimized development builds.
So this PR seems to make String.humanize_size() 4+ times faster.