Properly rename INSTANCE_ID and VERTEX_ID in canvas item shaders in the compatibility backend
#84585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he compatibility backend
lawnjelly
approved these changes
Nov 7, 2023
|
Thanks! |
akien-mga
changed the title
INSTANCE_ID and VERTEX_ID in canvas item shaders in the compatibility backendINSTANCE_ID and VERTEX_ID in canvas item shaders in the compatibility backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be unreported.
If a user tried to use
INSTANCE_IDorVERTEX_IDfrom a CanvasItem shader the shader would fail to compile without an error in the shader editor. They would get the huge OpenGL error printed out to console though.