Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store shader edit path in metadata #84628

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Nov 8, 2023

Fixes regression from #83137

The _edit_res_path meta was saved in the file. The code was inspired by script editor, but there the meta is applied to script sub-editors, not script themselves.

@KoBeWi KoBeWi added this to the 4.2 milestone Nov 8, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner November 8, 2023 18:16
_close_shader(i);
break;
Copy link
Member Author

@KoBeWi KoBeWi Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one shader can use a path.

@akien-mga akien-mga merged commit e5bacbc into godotengine:master Nov 8, 2023
14 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the no_meta_only_path branch November 8, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants