Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tile transforms handling cache to TileData #84660

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Move tile transforms handling cache to TileData #84660

merged 1 commit into from
Dec 14, 2023

Conversation

groud
Copy link
Member

@groud groud commented Nov 9, 2023 •
edited by KoBeWi
Loading

This PR does multiple things:

Bugsquad edit: Fixes #83825

@groud groud requested review from a team as code owners November 9, 2023 11:53
@groud groud requested a review from KoBeWi November 9, 2023 11:54
@YuriSizov YuriSizov added this to the 4.3 milestone Nov 9, 2023
@groud groud force-pushed the better_tileset_polygons branch 3 times, most recently from a6dbdc2 to ca65c8a Compare November 9, 2023 13:14
@groud groud requested review from a team as code owners November 9, 2023 13:14
@dsnopek
Copy link
Contributor

dsnopek commented Nov 9, 2023

I only looked at the GDExtension compatibility changes, but those look good to me!

AThousandShips
AThousandShips approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct otherwise

misc/extension_api_validation/4.1-stable.expected Outdated Show resolved Hide resolved
misc/extension_api_validation/4.1-stable.expected Outdated Show resolved Hide resolved
scene/resources/tile_set.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Nov 9, 2023
View reviewed changes
scene/resources/tile_set.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some minor optimization suggestions (they apply to physics and navigation too ofc), but otherwise looks fine.

raulsntos
raulsntos reviewed Nov 9, 2023
View reviewed changes
scene/resources/tile_set.compat.inc Outdated Show resolved Hide resolved
scene/resources/tile_set.compat.inc Outdated Show resolved Hide resolved
@groud groud force-pushed the better_tileset_polygons branch from ca65c8a to 216b280 Compare November 9, 2023 17:05
kleonc
kleonc reviewed Nov 10, 2023
View reviewed changes
modules/navigation/nav_mesh_generator_2d.cpp Outdated Show resolved Hide resolved
modules/navigation/nav_mesh_generator_2d.cpp Outdated Show resolved Hide resolved
scene/2d/tile_map.cpp Outdated Show resolved Hide resolved
scene/2d/tile_map.cpp Outdated Show resolved Hide resolved
scene/resources/tile_set.cpp Outdated Show resolved Hide resolved
scene/resources/tile_set.cpp Outdated Show resolved Hide resolved
scene/resources/tile_set.cpp Outdated Show resolved Hide resolved
AThousandShips
AThousandShips reviewed Nov 11, 2023
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed in docs

doc/classes/TileData.xml Outdated Show resolved Hide resolved
doc/classes/TileData.xml Outdated Show resolved Hide resolved
@groud groud force-pushed the better_tileset_polygons branch from 216b280 to 2bf4e32 Compare November 13, 2023 10:29
@groud
Copy link
Member Author

groud commented Nov 13, 2023

Thanks for the feedback @kleonc and @AThousandShips, should be fixed now :)

kleonc
kleonc approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@kleonc kleonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, just looked at the code changes, LGTM!

@groud groud mentioned this pull request Nov 15, 2023
Closed
@YuriSizov
Copy link
Contributor

@groud Could you address the comment above and do the rebase? Otherwise this seems to be good to go based on reviews.

@groud groud force-pushed the better_tileset_polygons branch from 2bf4e32 to 151f3f5 Compare December 13, 2023 15:30
@YuriSizov
Copy link
Contributor

Still has conflicts 🙃

@groud groud force-pushed the better_tileset_polygons branch from 151f3f5 to 0a3573c Compare December 13, 2023 16:02
@groud groud force-pushed the better_tileset_polygons branch from 0a3573c to 18fe0bd Compare December 13, 2023 16:45
@groud
Copy link
Member Author

groud commented Dec 13, 2023

@groud Could you address the comment above and do the rebase? Otherwise this seems to be good to go based on reviews.

Done.

Still has conflicts 🙃

Yeah, sorry for that, I forgot to rebase.

@groud groud mentioned this pull request Dec 14, 2023
Merged
@YuriSizov YuriSizov merged commit 4cf6325 into godotengine:master Dec 14, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov YuriSizov mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@akien-mga akien-mga akien-mga left review comments

@raulsntos raulsntos raulsntos left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

@kleonc kleonc kleonc approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:2d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Painting a rotated or flipped tile in a Tilemap loses collision
8 participants
@groud @dsnopek @YuriSizov @KoBeWi @raulsntos @akien-mga @kleonc @AThousandShips