Add OpenGL MSAA support to 2d rendering pipeline #84688
Draft
+100
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
force-pushed
the
gles3_msaa_2d
branch
from
cb8aa22
to
6670baa
Compare
BastiaanOlij
force-pushed
the
gles3_msaa_2d
branch
from
6670baa
to
852cad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds MSAA support to the 2D rendering pipeline. This is a work in progress and not yet functional.
Todos:
If available (OpenGLES only atm) this PR will use the GL_EXT_multisampled_render_to_texture extension resulting in automatic resolve and MSAA data remaining purely in tile memory. This should provide a marked performance improvement.
Due to the design of the renderer, if MSAA is both used for 2D and 3D, there isn't an ability to share buffers and we incur an overhead if blitting of MSAA buffers is required. If scaling is used this is also unavoidable.
Note that if the aforementioned extension is used, this is not an issue.
This is a follow up from #83976