Add region rect and frames support to Sprite2DPlugin converter #84754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aXu-AP
changed the title
KoBeWi
reviewed
Nov 11, 2023
KoBeWi
approved these changes
Nov 11, 2023
aXu-AP
force-pushed
the
sprite2dplugin-rect
branch
2 times, most recently
from
526a8bd
to
cc97747
Compare
Readds support for rects for sprite to mesh/polygon converter. Adds support for conversion from animation frame. Fixes converter not taking offset into account. Fixes 1 pixel shift when converting flipped sprites.
aXu-AP
force-pushed
the
sprite2dplugin-rect
branch
from
cc97747
to
cb88108
Compare
YuriSizov
changed the title
YuriSizov
changed the title
|
Thanks, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readds support for rects for sprite to mesh/polygon converter. (removed in #84361 due to feature being broken)
Adds support for conversion from animation frame (it was trivial to add and a +3-3 LOC change, so it felt reasonable to add).
Fixes converter not taking offset into account.
Fixes 1 pixel shift when converting flipped sprites (this seemed deliberate but maybe it is a legacy thing?).
Removes some comments which state the obvious (if these seem necessary after all we could just update them to adhere to comment style).