Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify description of "group selected" #84788

Merged

Conversation

Cerno-b
Copy link
Contributor

@Cerno-b Cerno-b commented Nov 12, 2023

I noticed that the tooltip for "Group selected" was misleading, because it described the feature as "make the children not selectable". However, the children are selectable in the scene view. Also the term "group" does not appear in the tooltip which I found makes it a bit confusing and seem like an incorrectly assigned description.

I'll take offers for improved wording of the text ;)

@Cerno-b Cerno-b requested a review from a team as a code owner November 12, 2023 10:28
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga added this to the 4.3 milestone Nov 12, 2023
@akien-mga akien-mga merged commit 54b83bd into godotengine:master Jan 3, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot commit -- far from your first contribution though ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants