-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Use get_instance_binding
instead of set
#84947
C#: Use get_instance_binding
instead of set
#84947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The code changes look good to me. As discussed on RocketChat, I think using get_instance_binding()
is correct for C#, and this should fix at least part of the WebRTCPeerConnection
issue. However, I haven't done any testing.
This has been confirmed to fix godotengine/webrtc-native#116 (see godotengine/webrtc-native#116 (comment)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I said previously, I haven't tested this code, but it looks good to me! Using get_instance_binding()
is definitely correct for this context
Thanks! |
Cherry-picked for 4.2.2. |
As discussed in RC, the C# wrapper types shouldn't be setting the
instance_binding
but instead getting it and using the create callback to add extra user data (like theCSharpScriptBinding
in our case).This should fix instantiating
WebRtcPeerConnection
but the linked issue seems to mention other problems so I'm not sure that it completely fixes it.