Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter groups and categories from autocompletion #85196

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Filter groups and categories from autocompletion #85196

merged 1 commit into from
Dec 5, 2023

Conversation

HolonProduction
Copy link
Member

@HolonProduction HolonProduction commented Nov 21, 2023 •
edited
Loading

Fixes #82785
Fixes #76919

@HolonProduction HolonProduction requested a review from a team as a code owner November 21, 2023 22:32
@dalexeev dalexeev added bug topic:gdscript topic:editor cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Nov 22, 2023
@dalexeev dalexeev added this to the 4.3 milestone Nov 22, 2023
YuriSizov
YuriSizov approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

We should probably pre-define PROPERTY_USAGE_SUBGROUP | PROPERTY_USAGE_GROUP | PROPERTY_USAGE_CATEGORY at some point. I think we use it everywhere now.

@HolonProduction HolonProduction force-pushed the completion-filter-groups branch from 053d0d8 to b33e04b Compare December 4, 2023 14:39
@YuriSizov
Copy link
Contributor

Oh, I didn't mean in this PR and not even in GDScript module. We use it everywhere in the codebase. It should be added as a pre-defined constant in the enumeration itself, I think. But not here, not in this PR.

@HolonProduction HolonProduction force-pushed the completion-filter-groups branch from b33e04b to e253250 Compare December 4, 2023 14:48
@akien-mga akien-mga merged commit 7c8dfea into godotengine:master Dec 5, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 5, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.1.

@HolonProduction HolonProduction deleted the completion-filter-groups branch December 9, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Built-in script section appears in autocompletion Weird things appear in autocomplete
4 participants
@HolonProduction @YuriSizov @akien-mga @dalexeev