Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AnimationPlaybackTrack keep state when stopping #85411

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Make AnimationPlaybackTrack keep state when stopping #85411

merged 1 commit into from
Nov 28, 2023

Conversation

TokageItLab
Copy link
Member

Fixes #85410.

The p_keep_state argument of stop of the child AniamtionPlayer should be true.

@TokageItLab TokageItLab added this to the 4.2 milestone Nov 27, 2023
@TokageItLab TokageItLab requested a review from a team as a code owner November 27, 2023 03:26
@fire fire changed the title Make AnimationPlaybakTrack keep state when stopping Make AnimationPlaybackTrack keep state when stopping Nov 27, 2023
@akien-mga akien-mga merged commit a008a85 into godotengine:master Nov 28, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@TokageItLab TokageItLab deleted the fix-animpbtrack-stop branch February 14, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:animation
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

AnimationPlaybackTrack assigned animation is seeked to 0 unintentionally after stopping host AnimationPlayer
2 participants
@TokageItLab @akien-mga