Improve CodeEdit to allow folding comment blocks

[SeremTitus]

allows foldable comments and extensible by taking prefix of a desired code block to make it foldable

• Bugsquad edit, closes: Add support for foldable comment blocks godot-proposals#8538

[Chaosus]

You need to squash the commits to a single one (see https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#modifying-a-pull-request)

[SeremTitus]

You need to squash the commits to a single one (see https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#modifying-a-pull-request)

squashed

[Calinou]

Thanks for opening a pull request 🙂

Feature pull requests should be associated to a feature proposal to justify the need for implementing the feature in Godot core. Please open a proposal on the Godot proposals repository (and link to this pull request in the proposal's body).

This feature looks interesting and I've seen it in a few other editors, although Visual Studio Code doesn't seem to feature this (or it's not enabled by default). It makes sense for license headers in particular, as these tend to span 10+ lines at the top of every file.

Having the collapse icon display for 2-line comments may end up looking noisy though. Perhaps we need a minimum number of consecutive comment lines before the folding icon is displayed (4 lines or so).

[AThousandShips]

I'd suggest building locally to find the errors in your code instead of taxing the CI with it, at least until you've ironed out some things

[AThousandShips]

Are you unable to build locally? You will be much more able to find errors in your code that way (and you aren't still having several errors in your code that were picked up by CI that remain) 🙂

(You should be compiling locally anyway to confirm that the code actually works)

[SeremTitus]

@AThousandShips , am adding minimum size which has come with some errors am sure I can iron them out in a couple of days...
And yes I can and do build locally it quite slow I cann't to seem to figure how to create a cache using scons, I prefer the CI but I will keep minimal use to this branch

[Yagich]

Is this not already a feature? On 4.2rc2, I have this:

[Yagich]

it might be an Easter egg

How so? It works as expected, and in line with the proposal you made.

[SeremTitus]

it might be an Easter egg

How so? It works as expected, and in line with the proposal you made.

It is a good mystery, I don't really know

[SeremTitus]

Does this feature exist in master?

[AThousandShips]

Go ahead and check in the release 🙂, see here

[SeremTitus]

It does it was introduce some where before 4.2.beta6, I do not know how I missed it . Am not sure when where how it was implimented though

[AThousandShips]

Already implemented by:

• Add code region folding to CodeEdit #74843 (might be mixing up, but already implemented)

I would say

This can be closed as the functionality is already present, if some improvements or other details can be added from this please open a new PR with those features 🙂

Thank you for your contribution nonetheless

[SeremTitus]

achieved by add_comment_delimiter("#","",)