-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for CameraAttributesPhysical.exposure_shutter_speed
#85599
Improve documentation for CameraAttributesPhysical.exposure_shutter_speed
#85599
Conversation
My bad got it backwards from the original
I like the wording here. "Allow" over "Let in" is less of a manner of speech, and more accessible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the property limits and suffix this change is correct
You had me second guessing myself here. Had to scramble to test it again to make sure I wasn't doing something stupid 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the wording and it looks good. Did not check if the math is flipped, but the conversation above seems to conclude that the math is correct.
Looks great! The final step before merging is to squash all the commits together so that the whole PR only contains 1 big commit with all your changes. We like to merge one commit at a time to keep the git history clean and navigable. If you don't know how to do that, we have a helpful tutorial in the official documentation https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase |
54d426d
to
3894fb2
Compare
Done. |
3894fb2
to
28f5f90
Compare
CameraAttributesPhysical.exposure_shutter_speed
Could you please amend your commit message to be a bit more descriptive? The current title of this PR is a good option. And you also don't need to include reviewers as co-authors, so that part of your commit message can be removed. |
28f5f90
to
1fdc1ea
Compare
My mistake. I thought I had already done it. |
1fdc1ea
to
b7b0022
Compare
Thanks! |
Cherry-picked for 4.2.1. |
Cherry-picked for 4.1.4. |
Fixes #85601